Hello, while looking at this driver for some pwm related changes, I noticed these two patch opportunities. Best regards Uwe Uwe Kleine-König (2): leds: qcom-lpg: Use devm_pwmchip_add() simplifying driver removal leds: qcom-lpg: Consistenly use dev_err_probe() in .probe()'s error path drivers/leds/rgb/leds-qcom-lpg.c | 52 +++++++++++--------------------- 1 file changed, 18 insertions(+), 34 deletions(-) base-commit: 8c9660f6515396aba78d1168d2e17951d653ebf2 -- 2.42.0