Hello Lee, On Thu, Nov 23, 2023 at 10:21:11AM +0000, Lee Jones wrote: > On Wed, 22 Nov 2023, Uwe Kleine-König wrote: > > Would you like it better then? > > It's definitely nicer to read and more in-line with the style I expect, > but the additional wrapper/abstraction layer is still bothersome. I guess that's subjective because I think having a separate pwm private data struct is nice. I don't see an immediate advantage for the leds-qcom-lpg driver, but the ti-sn65dsi86 driver could move some members of the parent driver to the pwm specific struct. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
