On Sun, Nov 05, 2023 at 04:49:39PM +0100, Stefan Wahren wrote: > In case leds-gpio fails to get the GPIO from the DT (e.g. the GPIO is > already requested) the driver doesn't provide any helpful error log: > > leds-gpio: probe of leds failed with error -16 > > So add a new error log in case devm_fwnode_gpiod_get() fails. ... > led.gpiod = devm_fwnode_gpiod_get(dev, child, NULL, GPIOD_ASIS, > NULL); > if (IS_ERR(led.gpiod)) { > + dev_err(dev, "Failed to get gpio '%pfw': %ld\n", > + child, PTR_ERR(led.gpiod)); Perhaps %pe ? > fwnode_handle_put(child); > return ERR_CAST(led.gpiod); > } -- With Best Regards, Andy Shevchenko