On Fri, Oct 06, 2023 at 03:24:04PM +0100, Mark Rutland wrote: > On Tue, Aug 01, 2023 at 05:16:23PM +0200, Marek Beh'un wrote: > > At the time we call > > BUG_ON(props.color == LED_COLOR_ID_MULTI); > > the props variable is still initialized to zero. > > > > Call the BUG_ON only after we parse fwnode into props. > > > > Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") > > Signed-off-by: Marek Beh'un <kabel@xxxxxxxxxx> > > I've just discovered this has broken boot on my Libre Computer > AML-A311D-CC-V0.2, which was working just fine with Debian 12's stock kernel: Sorry the the noise; I've just spotted this is fixed by: https://lore.kernel.org/linux-leds/20230918140724.18634-1-kabel@xxxxxxxxxx/ ... and I look forward to that hitting mainline :) Mark.