Re: [PATCH] leds: pwm: Don't disable the PWM when the LED should be off

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] leds: pwm: Don't disable the PWM when the LED should be off
From: Fabio Estevam <festevam@xxxxxxx>
Date: Fri, 22 Sep 2023 12:59:06 -0300
Cc: Pavel Machek <pavel@xxxxxx>, Lee Jones <lee@xxxxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, linux-leds@xxxxxxxxxxxxxxx, linux-pwm@xxxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx, Rogan Dawes <rogan@xxxxxxxxxxxx>
In-reply-to: <20230922142304.1685985-1-u.kleine-koenig@pengutronix.de>
References: <20230922142304.1685985-1-u.kleine-koenig@pengutronix.de>
User-agent: Roundcube Webmail/1.3.6

Hi Uwe,

On 22/09/2023 11:23, Uwe Kleine-König wrote:

 	led_dat->pwmstate.duty_cycle = duty;
-	led_dat->pwmstate.enabled = duty > 0;
+	led_dat->pwmstate.enabled = 1;


Thanks for the fix.

Nit: I would suggest:

led_dat->pwmstate.enabled = true;

Reviewed-by: Fabio Estevam <festevam@xxxxxxx>

References:
- [PATCH] leds: pwm: Don't disable the PWM when the LED should be off
  - From: Uwe Kleine-König

Prev by Date: [PATCH] leds: lp3952: replace deprecated strncpy with strscpy
Next by Date: [PATCH v2] leds: pwm: Don't disable the PWM when the LED should be off
Previous by thread: [PATCH] leds: pwm: Don't disable the PWM when the LED should be off
Next by thread: [PATCH] leds: lp3952: replace deprecated strncpy with strscpy
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]

Powered by Linux