Hello Lee,
I am sending version 4 of Turris Omnia's LED controller updates.
I tried to address the issues you mentioned:
- I made the omnia_cmd_read_raw() function to return the number of read
bytes on success
- I have renamed omnia_cmd_read() to omnia_cmd_read_u8() since it always
reads one byte. The function returns the read byte on success and
a negative errno on failure
- accordingly, I have renamed omnia_cmd_write() to omnia_cmd_write_u8(),
and made it so that it returns the number of written bytes on success
- the newly added comments now start with a capital letter
Marek
Marek Behún (4):
leds: turris-omnia: do not use SMBUS calls
leds: turris-omnia: make set_brightness() more efficient
leds: turris-omnia: support HW controlled mode via private trigger
leds: turris-omnia: add support for enabling/disabling HW gamma
correction
.../sysfs-class-led-driver-turris-omnia | 14 +
drivers/leds/Kconfig | 1 +
drivers/leds/leds-turris-omnia.c | 352 ++++++++++++++++--
3 files changed, 329 insertions(+), 38 deletions(-)
--
2.41.0
