On Fri, Sep 15, 2023 at 5:12 AM larry.lai <larry.lai@xxxxxxxxxxxxxxx> wrote: > The UP Squared board <http://www.upboard.com> implements certain > features (pin control) through an on-board FPGA. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Signed-off-by: Gary Wang <garywang@xxxxxxxxxxxx> > Signed-off-by: larry.lai <larry.lai@xxxxxxxxxxxxxxx> This v6 overall looks good to me! Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Can the patch be merged on its own? > +#include "core.h" > +#include "intel/pinctrl-intel.h" Didn't notice this before. But if Andy is OK with it, I'm OK with it, I guess there is a reason? Perhaps it warrants a comment explaining why you do this? Valid reasons: - You are using Intel-specific HW features also found in this FPGA Invalid reasons: - Using nifty macros or helpers, then either make them generic or (if they are small) duplicate them. If it was that thing I asked Andy to keep locally because I didn't agree with its generic usefulness, maybe I should be told to reconsider. Yours, Linus Walleij
