On Wed, 02 Aug 2023 11:07:53 +0200, Marek Behún wrote:
> The tty LED trigger uses the obsolete LED_ON & LED_OFF constants when
> setting LED brightness. This is bad because the LED_ON constant is equal
> to 1, and so when activating the tty LED trigger on a LED class device
> with max_brightness greater than 1, the LED is dimmer than it can be
> (when max_brightness is 255, the LED is very dimm indeed; some devices
> translate 1/255 to 0, so the LED is OFF all the time).
>
> [...]
Applied, thanks!
[1/1] leds: trigger: tty: Do not use LED_ON/OFF constants, use led_blink_set_oneshot instead
commit: 730094577e0c37e1bc40be37cbd41f71b0a8a2a4
--
Lee Jones [李琼斯]
