Stephan Gerhold писал(а) 15.08.2023 22:21: > AW2013 has an optional interrupt pin "INTN" which is used to report > completion of started operations (e.g. power up or LED breath effects). > The driver does not use it (yet) but it should be already described for > completeness inside the DT schema. > > Since the interrupt and I2C lines operate in open drain low active mode > a pull-up supply is needed for correct operation. Unfortunately there > is no ideal place to describe it in the DT: The pull-up needed for the > I2C lines could be described on the I2C bus. However, the pull-up > needed for the interrupt line belongs neither directly to the interrupt > controller nor to AW2013. Since the AW2013 driver will be typically in > control of the power management and interrupt masking it makes more > sense to describe it inside the AW2013 device tree node. > Oh indeed, seems like even on the hardware I was initially targeting, the pull is tied to a regulator, I probably missed it because it was always on. Thank you both for adding that and fixing up the bindings! Reviewed-by: Nikita Travkin <nikita@xxxxxxx> Nikita > Changes in v3: > - Rewrite commit messages based on discussion on v2 > - Also document missing interrupt in DT schema (new patch) > > Discussion on v2: > https://lore.kernel.org/linux-leds/20230321220825.GA1685482-robh@xxxxxxxxxx/ > > Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx> > --- > Lin, Meng-Bo (1): > leds: aw2013: Enable pull-up supply for interrupt and I2C > > Stephan Gerhold (2): > dt-bindings: leds: aw2013: Document interrupt > dt-bindings: leds: Document pull-up supply for interrupt and I2C > > .../devicetree/bindings/leds/leds-aw2013.yaml | 13 ++++++++ > drivers/leds/leds-aw2013.c | 36 +++++++++++++--------- > 2 files changed, 35 insertions(+), 14 deletions(-) > --- > base-commit: 841165267827955bb3295b066cb6a906ba9265c0 > change-id: 20230815-aw2013-vio-92a4566c5863 > > Best regards,
