Hello, On Mon, Jul 24, 2023 at 08:11:06AM +0200, Henning Schild wrote: > Am Mon, 24 Jul 2023 07:47:43 +0200 > schrieb Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>: > > > The .remove() callback for a platform driver returns an int which > > makes many driver authors wrongly assume it's possible to do error > > handling by returning an error code. However the value returned is > > (mostly) ignored and this typically results in resource leaks. To > > improve here there is a quest to make the remove callback return > > void. In the first step of this quest all drivers are converted to > > .remove_new() which already returns void. > > > > Make simatic_ipc_leds_gpio_remove() return void instead of returning > > zero unconditionally. After that the two remove callbacks were trivial > > to convert to return void, too. > > Thanks for taking care of that. There are currently two+ patch qs in > flight that would conflict with that, or rather need that done as well. Thanks for letting me know. As my patch is part of a bigger effort I will come back to it eventually. I won't resend now, I will wait at least until the two series you mentioned landed in next. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
