Am Tue, 18 Jul 2023 17:20:48 +0300 schrieb Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>: > On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote: > > If a user did choose to enable Siemens Simatic platform support they > > likely want that driver to be enabled without having to flip more > > config switches. So we make the watchdog driver config switch > > default to the platform driver switches value. > > A nit-pick below. > > ... > > > config SIEMENS_SIMATIC_IPC_WDT > > tristate "Siemens Simatic IPC Watchdog" > > depends on SIEMENS_SIMATIC_IPC > > > + default SIEMENS_SIMATIC_IPC > > It's more natural to group tristate and default, vs. depends and > select. Will be ignored unless maintainer insists. Henning > > > select WATCHDOG_CORE > > select P2SB >
