On Tue, Jul 11, 2023 at 9:13 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> Negative -EINVAL was intended, not positive EINVAL. Fix it.
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Thanks!
> Fixes: 95138e01275e ("leds: pwm: Make error handling more robust")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/leds/leds-pwm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
> index 29194cc382af..87c199242f3c 100644
> --- a/drivers/leds/leds-pwm.c
> +++ b/drivers/leds/leds-pwm.c
> @@ -146,7 +146,7 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
> led.name = to_of_node(fwnode)->name;
>
> if (!led.name) {
> - ret = EINVAL;
> + ret = -EINVAL;
> goto err_child_out;
> }
>
> --
> 2.39.2
>
--
With Best Regards,
Andy Shevchenko
