> +static ssize_t hw_control_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct led_netdev_data *trigger_data = led_trigger_get_drvdata
> (dev);
> +
> + return sprintf(buf, "%d\n", trigger_data->hw_control);
>
> [Kalesh]: How about using sysfs_emit?
Currently, there are zero instances of sysfs_emit() in ledtrig-netdev,
and in any files in drivers/leds/trigger/, or even drivers/leds.
So i think it would be better to keep this consistent with the rest of
the code in this file, and have a follow up patchset which reviews and
converts the 52 sprintf() in drivers/leds.
Andrew
