On Fri, Jun 09, 2023 at 03:51:03PM +0200, Christian Marangi wrote: > Add additional mode for unified tx/rx traffic. LED will blink on both tx > or rx traffic. > > This is especially useful for PHY and Switch that supports LEDs hw > control that doesn't support split tx/rx traffic but supports blinking > on any kind of traffic in the link. > > On mode set from sysfs we check if we have enabled split tx/rx mode and > reject enabling activity mode to prevent wrong and redundant > configuration. TRIGGER_NETDEV_TX + TRIGGER_NETDEV_RX = TRIGGER_NETDEV_ACTIVITY: When calling into the driver, it probably makes the drivers simpler if you do this simplification. Within the trigger code, keep them separate, because that is what the user has configured. I know such a simplification will make the marvell PHY driver simpler. Andrew
