On Tue, 23 May 2023, kernel test robot wrote: > Hi Martin, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on lee-leds/for-leds-next] > [also build test WARNING on wireless-next/main wireless/main linus/master v6.4-rc3 next-20230522] > [cannot apply to pavel-leds/for-next] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Martin-Kurbanov/leds-trigger-pattern-add-support-for-hrtimer/20230523-030630 > base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next > patch link: https://lore.kernel.org/r/20230522190412.374474-1-mmkurbanov%40sberdevices.ru > patch subject: [PATCH v1] leds: trigger: pattern: add support for hrtimer > config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230523/202305230549.ekneaQ89-lkp@xxxxxxxxx/config) > compiler: m68k-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/084f274c07fd243e864f73ab80a9eda5e940f024 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Martin-Kurbanov/leds-trigger-pattern-add-support-for-hrtimer/20230523-030630 > git checkout 084f274c07fd243e864f73ab80a9eda5e940f024 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/leds/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202305230549.ekneaQ89-lkp@xxxxxxxxx/ > > All warnings (new ones prefixed by >>): > > drivers/leds/trigger/ledtrig-pattern.c: In function 'pattern_init': > >> drivers/leds/trigger/ledtrig-pattern.c:454:74: warning: implicit conversion from 'enum <anonymous>' to 'enum pattern_type' [-Wenum-conversion] > 454 | err = pattern_trig_store_patterns(led_cdev, NULL, pattern, size, false); > | ^~~~~ Did you fix this already? I don't see a subsequent submission? > vim +454 drivers/leds/trigger/ledtrig-pattern.c > > 5fd752b6b3a223 Baolin Wang 2018-10-11 438 > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 439 static void pattern_init(struct led_classdev *led_cdev) > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 440 { > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 441 unsigned int size = 0; > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 442 u32 *pattern; > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 443 int err; > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 444 > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 445 pattern = led_get_default_pattern(led_cdev, &size); > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 446 if (!pattern) > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 447 return; > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 448 > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 449 if (size % 2) { > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 450 dev_warn(led_cdev->dev, "Expected pattern of tuples\n"); > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 451 goto out; > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 452 } > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 453 > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 @454 err = pattern_trig_store_patterns(led_cdev, NULL, pattern, size, false); > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 455 if (err < 0) > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 456 dev_warn(led_cdev->dev, > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 457 "Pattern initialization failed with error %d\n", err); > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 458 > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 459 out: > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 460 kfree(pattern); > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 461 } > aa6fd10481bdb1 Krzysztof Kozlowski 2019-01-09 462 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki -- Lee Jones [李琼斯]
