Am Tue, 16 May 2023 00:41:30 +0300 schrieb Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>: > On Mon, May 15, 2023 at 05:03:51PM +0200, Henning Schild wrote: > > In order to clearly describe the dependencies between the GPIO > > controller drivers and the users the driver is split up into a core, > > two drivers and a common header. > > AFAIU the GPIO lookup tables need a terminator entry. They never had one in the first place and that worked, i did not add terminators here and that also works. My guess is that .num_leds = ARRAY_SIZE(simatic_ipc_gpio_leds) tells "leds-gpio" how many entries there are. (another array without a terminator) But i will add them in a v4 so things are explicit and aligned with other similar drivers. Henning