On Tue, 25 Apr 2023, larry.lai wrote: > The UP Squared board <http://www.upboard.com> implements certain > features (pin control, onboard LEDs or CEC) through an on-board CPLD/FPGA. > > This mfd driver implements the line protocol to read and write registers > from the FPGA through regmap. The register address map is also included. > > The UP Boards provide a few I/O pin headers (for both GPIO and > functions), including a 40-pin Raspberry Pi compatible header. > > This patch implements support for the FPGA-based pin controller that > manages direction and enable state for those header pins. > > Partial support UP boards: > * UP core + CREX > * UP core + CRST02 > > Signed-off-by: Javier Arteaga <javier@xxxxxxxxxx> > [merge various fixes] > Signed-off-by: Nicola Lunghi <nicola.lunghi@xxxxxxxxxx> > Reviewed-by: Lee Jones <lee@xxxxxxxxxx> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Wait, what?! When did Andy or I provide you with Reviewed-by tags? You must to apply any tag that isn't explicitly provided to you. > Signed-off-by: larry.lai <larry.lai@xxxxxxxxxxxxxxx> > --- > RFC 2022/11/23 -> RFC 2023/04/25 > (1) Refer 2022/12/08 Andy Shevchenko review, cleaned up coding style > and addressed review comments. > PATCH V3 -> RFC 2022/11/23: > (1) Refer 2022/11/16 Lee Jones review, cleaned up coding style and > addressed review comments. > (2) Description on the UP Boards FPGA register read/write protocols > PATCH V2 -> V3: > (1) fixed kernel test robot compiler warning > PATCH V1 -> V2: > (1) Synchronizing upboard github to rc2 > (2) Refer 2022/10/31 Lee Jones review, fixed some of the issues. > --- > --- > drivers/mfd/Kconfig | 12 + > drivers/mfd/Makefile | 1 + > drivers/mfd/upboard-fpga.c | 527 +++++++++++++++++++++++++++++++ > include/linux/mfd/upboard-fpga.h | 61 ++++ > 4 files changed, 601 insertions(+) > create mode 100644 drivers/mfd/upboard-fpga.c > create mode 100644 include/linux/mfd/upboard-fpga.h I'm not even going to try and review this (again). Looking at the subject line, this is patch is masquerading as a RESEND of an unreviewed v1. However, at best this is a RESEND of a reviewed (which was ignored) v3, perhaps even just a straight v4. Either way, it appears as though the review comments you received in v3 were ignored. Please go back and fix those before submitting v5, thanks. -- Lee Jones [李琼斯]
