Hi, OK, I will test the latest version near the weekend and will reply with Tested-by if all will be fine. вт, 25 апр. 2023 г. в 16:37, Hans de Goede <hdegoede@xxxxxxxxxx>: > > Hi Yauhen, > > On 4/16/23 15:04, Hans de Goede wrote: > > Hi Yauhen, > > > > On 4/15/23 22:32, Yauhen Kharuzhy wrote: > >> On Thu, Apr 13, 2023 at 05:18:03PM +0200, Hans de Goede wrote: > >>> Hi All, > >>> > >>> Here is a patch series to add support for the LED controller on > >>> Intel Cherry Trail Whiskey Cove PMICs. > >>> > >>> This is based on the original patch for this from Yauhen Kharuzhy, > >>> with additional work on top by me. > >>> > >>> This addresses the review remarks on the v2 posting from Yauhen: > >>> - Since the PMIC is connected to the battery any changes we make to > >>> the LED settings are permanent, even surviving reboot / poweroff. > >>> Save LED1 register settings on probe() and if auto-/hw-control was > >>> enabled on probe() restore the settings on remove() and shutdown(). > >>> - Add support for the pattern trigger to select breathing mode > >>> > >>> This makes the charging LED on devices with these PMICs properly > >>> reflect the charging status (this relies on sw control on most > >>> devices) and this also allows control of the LED behind the pen > >>> (digitizer on) symbol on the keyboard half of the Lenovo Yoga Book > >>> 1 models. > >>> > >>> Regards, > >>> > >>> Hans > >>> > >>> > >>> Hans de Goede (4): > >>> leds: cht-wcove: Add suspend/resume handling > >>> leds: cht-wcove: Add support for breathing mode use hw_pattern sysfs > >>> API > >>> leds: cht-wcove: Set default trigger for charging LED > >>> leds: cht-wcove: Use breathing when LED_INIT_DEFAULT_TRIGGER is set > >>> > >>> Yauhen Kharuzhy (1): > >>> leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver > >>> > >>> Documentation/leds/index.rst | 1 + > >>> Documentation/leds/leds-cht-wcove.rst | 29 ++ > >>> drivers/leds/Kconfig | 11 + > >>> drivers/leds/Makefile | 1 + > >>> drivers/leds/leds-cht-wcove.c | 466 ++++++++++++++++++++++++++ > >>> 5 files changed, 508 insertions(+) > >>> create mode 100644 Documentation/leds/leds-cht-wcove.rst > >>> create mode 100644 drivers/leds/leds-cht-wcove.c > >> > >> Hi Hans, > >> > >> Thanks for reviving this patch! > > > > You're welcome. > > > >> I haven't tested it on linux-next yet but on v6.2.11 (with few patches for > >> Yoabook) I catched following trace. I will investigate it later but maybe you > >> can take a look also? > > > > Right, this is an unrelated pre-existing kernel bug when using > > led_trigger_blink(). > > > > I already hit that myself and I have a fix for it, see this series: > > https://lore.kernel.org/linux-leds/20230412215855.593541-1-hdegoede@xxxxxxxxxx/ > > Lee is asking for testers of this series, if you have time it would be > good if you can give this series a try in combination with this new > leds-cht-wcove driver. > > Assuming the other series fixed the oops/backtrace for you can you > please reply with your Tested-by to that series: > > https://lore.kernel.org/linux-leds/20230412215855.593541-1-hdegoede@xxxxxxxxxx/ > > (or even better give your Tested-by for both series) > > Regards, > > Hans > -- Yauhen Kharuzhy
