On 4/24/23 16:16, Lee Jones wrote:
Jacek,
On Thu, 20 Apr 2023, Hans de Goede wrote:
The hw-blinking of the LED controller in the Whiskey Cove PMIC can also
be used for a hw-breathing effect.
As discussed during review of v2 of the submission of the new
leds-cht-wcove driver, the LED subsystem already supports breathing mode
on several other LED controllers using the hw_pattern interface.
Implement a pattern_set callback to implement breathing mode modelled
after the breathing mode supported by the SC27xx breathing light and
Crane EL15203000 LED drivers. The Whiskey Cove PMIC's breathing mode
is closer to the EL15203000 one then to the SC27xx one since it does
not support staying high / low for a specific time, it only supports
rise and fall times.
As such the supported hw_pattern and the documentation for this is almost
a 1:1 copy of the pattern/docs for the EL15203000 breathing mode.
Suggested-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
Is this what you were after?
I remember I recommended to Hans using pattern trigger for hw patterns
somewhere in 2019, so yes.
Link: https://lore.kernel.org/all/6beed61c-1fc6-6525-e873-a8978f5fbffb@xxxxxxxxx/
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
---
Changes in v2
- Improve/extend Documentation/leds/leds-cht-wcove.rst a bit
--
Best regards,
Jacek Anaszewski
