On Wed, 19 Apr 2023, Christian Marangi wrote: > Putting NETDEV_LED_MODE_LINKUP in the same list of the netdev trigger > modes is wrong as it's used to set the link state of the device and not > to set a blink mode as it's done by NETDEV_LED_LINK, NETDEV_LED_TX and > NETDEV_LED_RX. It's also wrong to put this state in the same bitmap of the > netdev trigger mode and should be external to it. > > Drop NETDEV_LED_MODE_LINKUP from mode list and convert to a simple bool > that will be true or false based on the carrier link. No functional > change intended. > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > --- > drivers/leds/trigger/ledtrig-netdev.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) Applied, thanks -- Lee Jones [李琼斯]
