On Tue, 11 Apr 2023, Rob Herring wrote: > On Fri, Apr 07, 2023 at 12:23:23PM +0200, Maarten Zanders wrote: > > Add a binding to configure the internal charge pump for lp55xx. > > > > Signed-off-by: Maarten Zanders <maarten.zanders@xxxxxxx> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > > > Notes: > > v1: implement as bool to disable charge pump > > v2: rewrite to use string configuration, supporting all modes > > v3: simplification by replacing string option by u8 constant, > > removing previous Reviewed-by tags as it's a complete > > rewrite of the patch. > > v4: added notes > > v5: dual license, change property type to u32 > > v6: change license type for leds-lp-55xx.h to preferred tag > > > > .../devicetree/bindings/leds/leds-lp55xx.yaml | 8 ++++++++ > > include/dt-bindings/leds/leds-lp55xx.h | 10 ++++++++++ > > 2 files changed, 18 insertions(+) > > create mode 100644 include/dt-bindings/leds/leds-lp55xx.h > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > > index ae607911f1db..ede9cb9ca175 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > > +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > > @@ -66,6 +66,12 @@ properties: > > '#size-cells': > > const: 0 > > > > + ti,charge-pump-mode: > > + description: > > + Set the operating mode of the internal charge pump as defined in > > + <dt-bindings/leds/leds-lp55xx.h>. Defaults to auto. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > Needs constraints: > > default: 3 # Auto > maximum: 3 Once this has been fixed, I'll apply both. -- Lee Jones [李琼斯]
