On 4/12/2023 4:11 PM, Christian Marangi wrote:
On Thu, Apr 13, 2023 at 06:57:51AM -0700, Florian Fainelli wrote:
On 3/27/2023 7:10 AM, Christian Marangi wrote:
From: Andrew Lunn <andrew@xxxxxxx>
Linux LEDs can be software controlled via the brightness file in /sys.
LED drivers need to implement a brightness_set function which the core
will call. Implement an intermediary in phy_device, which will call
into the phy driver if it implements the necessary function.
Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
+ int (*led_brightness_set)(struct phy_device *dev,
+ u32 index, enum led_brightness value);
I think I would have made this an u8, 4 billion LEDs, man, that's a lot!
If andrew is ok we can still consider to reduce it. (but just to joke
about it... A MAN CAN DREAM OF A FULL HD SCREEN ON THEIR OWN SPECIAL
PORT)
Humm just thought of something else, is it OK for led_brightness_set and
led_blink_set to call into functions that might require sleeping (MDIO,
I2C, SPI, etc.)?
--
Florian
