Hi!
> Add basic code to turn on and off WLEDs and wire up MT6332 support
> to take advantage of it.
> This is a simple approach due to to the aforementioned PMIC supporting
> only on/off status so, at the time of writing, it is impossible for me
> to validate more advanced functionality due to lack of hardware.
> @@ -467,14 +590,24 @@ static int mt6323_led_probe(struct platform_device *pdev)
> goto put_child_node;
> }
>
> + is_wled = of_property_read_bool(child, "mediatek,is-wled");
> +
This needs documenting in the binding, no?
> +static const struct mt6323_hwspec mt6332_spec = {
> + /* There are no LEDs in MT6332. Only WLEDs are present. */
"Only WLED is present"?
> + .max_leds = 0,
> + .max_wleds = 1,
> + .max_brightness = 1024,
> +};
> +
Is there chip with both LED and WLEDs? (I'm wondering if this makes
sense in single driver).
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Attachment:
signature.asc
Description: PGP signature
