Hi Andreas, Thanks for the patch! Adding new support for devices is Much Appreciated! On 4/6/23 09:08, Andreas Kemnade wrote:
Document ROHM BD2606MVV LED driver devicetree bindings. Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx> --- .../bindings/leds/rohm,bd2606mvv.yaml | 76 +++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml new file mode 100644 index 0000000000000..6d4ddd8d31162 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml @@ -0,0 +1,76 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/rohm,bd2606mvv.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: BD2606MVV LED controller + +maintainers: + - Andreas Kemnade <andreas@xxxxxxxxxxxx> + +description: + The BD2606 MVV is a programmable LED controller connected via I2C that can + drive 6 separate lines. Each of them can be individually switched on and off + but the brightness setting is shared between two of them.
Maybe add a link to data-sheet? https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/led_driver/bd2606mvv_1-e.pdf
+ +properties: + compatible: + const: rohm,bd2606mvv + + reg: + description: I2C slave address of the controller. + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@[0-6]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + minimum: 0 + maximum: 6 + + required: + - reg + +additionalProperties: false
According to the data-sheet, BD2606 has an enable-pin. Should it be visible in the bindings?
Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~
