Hi!
> > > The WAN port of the 370-RD has a Marvell PHY, with one LED on
> > > the front panel. List this LED in the device tree.
> > >
> > > Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
> > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> >
> > > @@ -135,6 +136,19 @@ &mdio {
> > > pinctrl-names = "default";
> > > phy0: ethernet-phy@0 {
> > > reg = <0>;
> > > + leds {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + led@0 {
> > > + reg = <0>;
> > > + label = "WAN";
> > > + color = <LED_COLOR_ID_WHITE>;
> > > + function = LED_FUNCTION_LAN;
> > > + function-enumerator = <1>;
> > > + linux,default-trigger = "netdev";
> > > + };
> > > + };
> > > };
> > >
> >
> > How will this end up looking in sysfs?
>
> Hi Pavel
>
> It is just a plain boring LED, so it will look like all other LEDs.
> There is nothing special here.
Well, AFAICT it will end up as /sys/class/leds/WAN, which is really
not what we want. (Plus the netdev trigger should be tested; we'll
need some kind of link to the ethernet device if we want this to work
on multi-ethernet systems).
> > Should documentation be added to Documentation/leds/leds-blinkm.rst
> > ?
>
> This has nothing to do with blinkm, which appears to be an i2c LED
> driver.
Sorry, I meant
Should documentation be added to Documentation/leds/well-known-leds.txt ?
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Attachment:
signature.asc
Description: PGP signature
