Re: [PATCH 0/3] Documentation fixes for MT6370 RGB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 23 Mar 2023, Bagas Sanjaya wrote:

> On 3/19/23 14:49, Bagas Sanjaya wrote:
> > kernel test robot recently reported htmldocs warnings on documentation
> > for MT6370 RGB LED. So here are the fixes.
> >
> > Bagas Sanjaya (3):
> >   Documentation: leds: Add MT6370 doc to the toctree
> >   Documentation: leds: MT6370: Properly wrap hw_pattern chart
> >   Documentation: leds: MT6370: Use bullet lists for timing variables
> >
> >  Documentation/leds/index.rst           |  1 +
> >  Documentation/leds/leds-mt6370-rgb.rst | 42 +++++++++++++-------------
> >  2 files changed, 22 insertions(+), 21 deletions(-)
> >
> >
> > base-commit: 4ba9df04b7ac66d2d000ed7ae2d8136302d99a57
>
> ping

a) Don't do that!

b) Especually don't do that 4 days after submission!

The usual expectation is 2 full weeks before submitting a [RESEND].

Mark Brown says it best:

"
Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.
"

--
Lee Jones [李琼斯]



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux