Re: [PATCH] leds: mt6360: Add missing fwnode_handle_put()

[Pavel Machek <pavel@xxxxxx>]

Hi!

> In mt6360_init_isnk_properties(), we should add
> fwnode_handle_put() when break out of the iteration
> fwnode_for_each_child_node() as it will automatically
> increase and decrease the refcounter.
> 
> Fixes: 679f8652064b ("leds: Add mt6360 driver")
> Signed-off-by: Liang He <windhl@xxxxxxx>

I believe you got indentation wrong on }.

With that fixed:

Acked-by: Pavel Machek <pavel@xxxxxx>

BR,
							Pavel

> +++ b/drivers/leds/flash/leds-mt6360.c
> @@ -637,14 +637,17 @@ static int mt6360_init_isnk_properties(struct mt6360_led *led,
>  
>  			ret = fwnode_property_read_u32(child, "reg", &reg);
>  			if (ret || reg > MT6360_LED_ISNK3 ||
> -			    priv->leds_active & BIT(reg))
> +			    priv->leds_active & BIT(reg)) {
> +				fwnode_handle_put(child);
>  				return -EINVAL;
> +				}
>  
>  			ret = fwnode_property_read_u32(child, "color", &color);
>  			if (ret) {
>  				dev_err(priv->dev,
>  					"led %d, no color specified\n",
>  					led->led_no);
> +				fwnode_handle_put(child);
>  				return ret;
>  			}
>  

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Attachment: signature.asc
Description: PGP signature