On Tue, 07 Mar 2023, ChiYuan Huang wrote: > Hi, Lee: > > Some question about the comment. > On Sun, Mar 05, 2023 at 10:18:24AM +0000, Lee Jones wrote: > > On Thu, 23 Feb 2023, ChiaEn Wu wrote: > > > > > From: ChiYuan Huang <cy_huang@xxxxxxxxxxx> > > > > > > Document the MT6370 RGB LED pattern trigger. > > > > > > This simply describe how the pattern works, each timing period, and the > > > pattern diagram for MT6370 RGB LED. > > > > > > Signed-off-by: ChiYuan Huang <cy_huang@xxxxxxxxxxx> > > > Signed-off-by: ChiaEn Wu <chiaen_wu@xxxxxxxxxxx> > > > --- > > > Documentation/leds/leds-mt6370-rgb.rst | 64 ++++++++++++++++++++++++++++++++++ > > > 1 file changed, 64 insertions(+) > > > create mode 100644 Documentation/leds/leds-mt6370-rgb.rst > > > > > > diff --git a/Documentation/leds/leds-mt6370-rgb.rst b/Documentation/leds/leds-mt6370-rgb.rst > > > new file mode 100644 > > > index 00000000..d1b2e4f > > > --- /dev/null > > > +++ b/Documentation/leds/leds-mt6370-rgb.rst > > > @@ -0,0 +1,64 @@ > > > +.. SPDX-License-Identifier: GPL-2.0 > > > + > > > +========================================= > > > +Kernel driver for Mediatek MT6370 RGB LED > > > > Are you describing the device or the kernel driver? > > > But referring to others, it seems each one also write this as 'Kernel driver'. > Sorry, I cannot catch the point. Did you mean to modify this description as > 'The device for MT6370 RGB LED'? Just because it's been done before, doesn't make it right. IMHO, this document should describe the device, not the driver. -- Lee Jones [李琼斯]
