On Wed, Mar 08, 2023 at 12:20:17AM +0100, Andrew Lunn wrote: > On Tue, Mar 07, 2023 at 06:00:46PM +0100, Christian Marangi wrote: > > From: Andrew Lunn <andrew@xxxxxxx> > > > > The WAN port of the 370-RD has a Marvell PHY, with one LED on > > the front panel. List this LED in the device tree. > > > > Set the LED default state to "keep" to not change any blink rule > > set by default. > > Hi Christian > > What board are you using for testing? It would be good to patch its > .dts file to enable its LEDs. We don't normally had new code without a > user. > ipq806x, my specific device is not present upstream but we have a rb3011 that currently use the qca8k dsa switch upstream. If needed I can add support there by checking the leds supported... Also looking at the dt I think I need to use "port - 1" after all since it does use legacy way... Sad me... -- Ansuel