On Wed, Mar 01, 2023 at 06:02:13PM +0100, Henning Schild wrote: > There are two special pins needed to init the LEDs. We used to have them > at the end of the gpiod_lookup table to give to "leds-gpio". A cleaner > way is to have a dedicated table for the special pins. ... > + .dev_id = NULL, Technically speaking this is redundant. Maybe you wanted to be more explicit with a comment like .dev_id = NULL, /* Filled during initialization */ ... > + .dev_id = NULL, Ditto. -- With Best Regards, Andy Shevchenko
