On Wed, 01 Mar 2023, Pavel Machek wrote: > Hi! > > > > > +config LEDS_AW200XX > > > > + tristate "LED support for Awinic AW20036/AW20054/AW20072" > > > > + depends on LEDS_CLASS > > > > + depends on I2C > > > > + help > > > > + This option enables support for the AW20036/AW20054/AW20072 LED driver. > > > > + It is a 3x12/6x9/6x12 matrix LED driver programmed via > > > > + an I2C interface, up to 36/54/72 LEDs or 12/18/24 RGBs, > > > > + 3 pattern controllers for auto breathing or group dimming control. > > > > > > I'm afraid this should be handled as a display, not as an array of > > > individual LEDs. > > > > Just for my own information, where do we draw the line on this? > > Not sure. > > > Is 4x4 okay? How about 6x6? > > I'd say "As soon as it is 2-dimensional". Even 3x2 array is a display. > > If the LEDs are independend, and it makes sense to display disk > activity on one and CPU activity on second... that's for LED > subsystem. > > When userspace needs to know where are the LEDs spatially located, and > when you start putting synchronized animations over the LEDs... well, > then maybe that's a display. > > 6x9 is definitely a display. We won't put 1920x1080 phone display into > drivers/leds just because it is OLED... Got it, thank you Pavel. -- Lee Jones [李琼斯]
