Hi, On 2/27/23 17:07, Randy Dunlap wrote: > > > On 2/27/23 01:31, Hans de Goede wrote: >> Hi Randy, >> >> On 2/26/23 06:39, Randy Dunlap wrote: >>> REGMAP is a hidden (not user visible) symbol. Users cannot set it >>> directly thru "make *config", so drivers should select it instead of >>> depending on it if they need it. >>> >>> Consistently using "select" or "depends on" can also help reduce >>> Kconfig circular dependency issues. >>> >>> REGMAP is selected 94 times and is depended on 11 times in >>> current linux-next. Eliminate the uses of "depends on" by >>> converting them to "select". >> >> Thank you for your work on this. Mixing of depends on vs select >> is a real problem with many Kconfig symbols. >> >>> [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it >>> [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it >>> [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it >>> [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it >>> [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it >>> [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it >>> [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it >>> [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it >> >> For patch 5/8 and 6/8, do you want me to merge them through the pdx86 >> (platform-drivers-x86) tree, or do you plan to merge this whole series >> in one go through some other tree? > > Hi Hans, > Please merge them thru the pdx86 tree. Ok, I've applied patch 5/8 + 6/8 to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans I'll rebase that branch once 6.3-rc1 is out and then push the rebased patch to the fixes branch and include it in my next 6.3 fixes pull-req to Linus. Regards, Hans >>> >>> diffstat: >>> drivers/char/ipmi/Kconfig | 3 ++- >>> drivers/clk/Kconfig | 2 +- >>> drivers/gpio/Kconfig | 2 +- >>> drivers/leds/Kconfig | 2 +- >>> drivers/platform/mellanox/Kconfig | 9 ++++----- >>> drivers/platform/x86/Kconfig | 3 ++- >>> drivers/thermal/intel/Kconfig | 3 ++- >>> drivers/tty/serial/8250/Kconfig | 3 ++- >>> 8 files changed, 15 insertions(+), 12 deletions(-) >>> >>> Cc: Andrew Jeffery <andrew@xxxxxxxx> >>> Cc: Corey Minyard <minyard@xxxxxxx> >>> Cc: openipmi-developer@xxxxxxxxxxxxxxxxxxxxx >>> Cc: Arnd Bergmann <arnd@xxxxxxxx> >>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >>> Cc: Riku Voipio <riku.voipio@xxxxxxxxxx> >>> Cc: Stephen Boyd <sboyd@xxxxxxxxxx> >>> Cc: Michael Turquette <mturquette@xxxxxxxxxxxx> >>> Cc: linux-clk@xxxxxxxxxxxxxxx >>> Cc: Michael Walle <michael@xxxxxxxx> >>> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> >>> Cc: Bartosz Golaszewski <brgl@xxxxxxxx> >>> Cc: linux-gpio@xxxxxxxxxxxxxxx >>> Cc: Dan Murphy <dmurphy@xxxxxx> >>> Cc: Pavel Machek <pavel@xxxxxx> >>> Cc: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> >>> Cc: Lee Jones <lee@xxxxxxxxxx> >>> Cc: linux-leds@xxxxxxxxxxxxxxx >>> Cc: Darren Hart <dvhart@xxxxxxxxxxxxx> >>> Cc: Hans de Goede <hdegoede@xxxxxxxxxx> >>> Cc: Michael Shych <michaelsh@xxxxxxxxxx> >>> Cc: Mark Gross <markgross@xxxxxxxxxx> >>> Cc: Vadim Pasternak <vadimp@xxxxxxxxxx> >>> Cc: platform-driver-x86@xxxxxxxxxxxxxxx >>> Cc: Yegnesh S Iyer <yegnesh.s.iyer@xxxxxxxxx> >>> Cc: Bin Gao <bin.gao@xxxxxxxxx> >>> Cc: Zhang Rui <rui.zhang@xxxxxxxxx> >>> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx> >>> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> >>> Cc: Amit Kucheria <amitk@xxxxxxxxxx> >>> Cc: linux-pm@xxxxxxxxxxxxxxx >>> Cc: Oskar Senft <osk@xxxxxxxxxx> >>> Cc: linux-serial@xxxxxxxxxxxxxxx >>> >> >
