Re: [PATCH] leds: trigger/tty: Add knob to blink only for tx or only for rx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu 2023-02-23 16:17:12, Alexander Dahl wrote:
> Hei hei,
> 
> Am Thu, Feb 24, 2022 at 04:56:55PM +0100 schrieb Uwe Kleine-König:
> > The newly introduced "triggerevent" attribute allows to restrict
> > blinking to TX or RX only.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> This patch has not been merged, has it?
> 
> What's the state of it?  Fell through the cracks or denied?
> 
> I'd have a usecase for it. O:-)

My notes say:

> But... I don't think sysfs interface is acceptable due to "one value per file" sysfs rule.
>
> Separate "blink for tx" and "blink for rx" files containing booleans should be acceptable.
>
> Best regards,
>                                                                               Pavel


...and that's still relevant:

> > +++ b/Documentation/ABI/testing/sysfs-class-led-trigger-tty
> > @@ -4,3 +4,12 @@ KernelVersion:	5.10
> >  Contact:	linux-leds@xxxxxxxxxxxxxxx
> >  Description:
> >  		Specifies the tty device name of the triggering tty
> > +
> > +What:		/sys/class/leds/<led>/triggerevent
> > +Date:		Feb 2022
> > +KernelVersion:	5.18
> > +Contact:	linux-leds@xxxxxxxxxxxxxxx
> > +Description:
> > +		Can contain "tx', "rx" (to only blink on transfers
> > +		in the specified direction) or "both" (to blink for
> > +		both directions.)

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux