Hi, On 2/13/23 13:45, Kate Hsuan wrote: > Add flags for both LEDA(TPS68470_ILEDCTL_ENA), LEDB > (TPS68470_ILEDCTL_ENB), and current control mask for LEDB > (TPS68470_ILEDCTL_CTRLB) > > Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans > --- > include/linux/mfd/tps68470.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mfd/tps68470.h b/include/linux/mfd/tps68470.h > index 7807fa329db0..2d2abb25b944 100644 > --- a/include/linux/mfd/tps68470.h > +++ b/include/linux/mfd/tps68470.h > @@ -34,6 +34,7 @@ > #define TPS68470_REG_SGPO 0x22 > #define TPS68470_REG_GPDI 0x26 > #define TPS68470_REG_GPDO 0x27 > +#define TPS68470_REG_ILEDCTL 0x28 > #define TPS68470_REG_VCMVAL 0x3C > #define TPS68470_REG_VAUX1VAL 0x3D > #define TPS68470_REG_VAUX2VAL 0x3E > @@ -94,4 +95,8 @@ > #define TPS68470_GPIO_MODE_OUT_CMOS 2 > #define TPS68470_GPIO_MODE_OUT_ODRAIN 3 > > +#define TPS68470_ILEDCTL_ENA BIT(2) > +#define TPS68470_ILEDCTL_ENB BIT(6) > +#define TPS68470_ILEDCTL_CTRLB GENMASK(5, 4) > + > #endif /* __LINUX_MFD_TPS68470_H */