Am Tue, 21 Feb 2023 15:51:03 +0200 schrieb Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>: > On Tue, Feb 21, 2023 at 01:24:13PM +0100, Henning Schild wrote: > > In order to clearly describe the dependencies between the gpio > > GPIO > > > controller drivers and the users the driver is split up into two > > and one > > one --> a > > > common header. > > ... > > > + * Authors: > > (everywhere where it is a single author, 's' is redundant) > > ... > > > +#ifndef __DRIVERS_LEDS_SIMPLE_SIMATIC_IPC_LEDS_GPIO > > +#define __DRIVERS_LEDS_SIMPLE_SIMATIC_IPC_LEDS_GPIO > > > +#endif /* __DRIVERS_LEDS_SIMPLE_SIMATIC_IPC_LEDS_GPIO */ > > This header doesn't look right. > > Have you run `make W=1 ...` against your patches? No reports. > Even if it doesn't show defined but unused errors > the idea is that this should be a C-file, called, > let's say, ...-core.c. When i started i kind of had a -common.c in mind as well. But then the header idea came and i gave it a try, expecting questions in the review. It might be a bit unconventional but it seems to do the trick pretty well. Do you see a concrete problem or a violation of a rule? Henning
