Hi Florian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on tty/tty-next tty/tty-linus pavel-leds/for-next staging/staging-testing staging/staging-next staging/staging-linus linus/master v6.2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Florian-Eckert/tty-new-helper-function-tty_get_mget/20230220-232129 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing patch link: https://lore.kernel.org/r/20230220152038.3877596-3-fe%40dev.tdt.de patch subject: [PATCH v4 2/2] trigger: ledtrig-tty: add additional modes config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230221/202302210614.4oTMenu2-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/8da3a8a2edcad2e4b36fce551cac1961a5cd90a6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Florian-Eckert/tty-new-helper-function-tty_get_mget/20230220-232129 git checkout 8da3a8a2edcad2e4b36fce551cac1961a5cd90a6 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/leds/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202302210614.4oTMenu2-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/leds/trigger/ledtrig-tty.c:15:24: error: 'TTY_LED_RNG' undeclared here (not in a function); did you mean 'TTY_LED_CNT'? 15 | TTY_LED_LAST = TTY_LED_RNG | ^~~~~~~~~~~ | TTY_LED_CNT drivers/leds/trigger/ledtrig-tty.c:33:10: error: array index in initializer not of integer type 33 | [TTY_LED_RNG] = "RNG", // RNG Ring Indicator (RI) | ^~~~~~~~~~~ drivers/leds/trigger/ledtrig-tty.c:33:10: note: (near initialization for 'mode') drivers/leds/trigger/ledtrig-tty.c: In function 'ledtrig_tty_mode_show': drivers/leds/trigger/ledtrig-tty.c:48:34: error: '__TTY_LED_LAST' undeclared (first use in this function); did you mean 'TTY_LED_LAST'? 48 | bool last = i == __TTY_LED_LAST; | ^~~~~~~~~~~~~~ | TTY_LED_LAST drivers/leds/trigger/ledtrig-tty.c:48:34: note: each undeclared identifier is reported only once for each function it appears in drivers/leds/trigger/ledtrig-tty.c:50:48: warning: too many arguments for format [-Wformat-extra-args] 50 | len += sysfs_emit_at(buf, len, "%s%s%s", | ^~~~~~~~ drivers/leds/trigger/ledtrig-tty.c: In function 'tty_led_mode_store': drivers/leds/trigger/ledtrig-tty.c:81:38: error: '__TTY_LED_MAX' undeclared (first use in this function); did you mean 'TTY_LED_CAR'? 81 | enum tty_led_mode tty_mode = __TTY_LED_MAX; | ^~~~~~~~~~~~~ | TTY_LED_CAR drivers/leds/trigger/ledtrig-tty.c:88:26: error: '__TTY_LED_LAST' undeclared (first use in this function); did you mean 'TTY_LED_LAST'? 88 | for (i = 0; i <= __TTY_LED_LAST; i++) | ^~~~~~~~~~~~~~ | TTY_LED_LAST drivers/leds/trigger/ledtrig-tty.c:89:17: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 89 | if (strncmp(buf, mode[i], size) == 0) | ^~ drivers/leds/trigger/ledtrig-tty.c:91:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 91 | break; | ^~~~~ drivers/leds/trigger/ledtrig-tty.c:91:25: error: break statement not within loop or switch drivers/leds/trigger/ledtrig-tty.c:81:27: warning: variable 'tty_mode' set but not used [-Wunused-but-set-variable] 81 | enum tty_led_mode tty_mode = __TTY_LED_MAX; | ^~~~~~~~ >> drivers/leds/trigger/ledtrig-tty.c:80:17: warning: unused variable 'ret' [-Wunused-variable] 80 | ssize_t ret = size; | ^~~ >> drivers/leds/trigger/ledtrig-tty.c:79:34: warning: unused variable 'trigger_data' [-Wunused-variable] 79 | struct ledtrig_tty_data *trigger_data = led_trigger_get_drvdata(dev); | ^~~~~~~~~~~~ drivers/leds/trigger/ledtrig-tty.c:92:17: error: no return statement in function returning non-void [-Werror=return-type] 92 | } | ^ drivers/leds/trigger/ledtrig-tty.c: At top level: drivers/leds/trigger/ledtrig-tty.c:94:9: error: expected identifier or '(' before 'if' 94 | if (tty_mode > __TTY_LED_LAST) | ^~ In file included from include/linux/rhashtable-types.h:14, from include/linux/ipc.h:7, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/sched.h:15, from include/linux/delay.h:23, from drivers/leds/trigger/ledtrig-tty.c:3: drivers/leds/trigger/ledtrig-tty.c:97:20: error: expected declaration specifiers or '...' before '&' token 97 | mutex_lock(&trigger_data->mutex); | ^ include/linux/mutex.h:187:44: note: in definition of macro 'mutex_lock' 187 | #define mutex_lock(lock) mutex_lock_nested(lock, 0) | ^~~~ include/linux/mutex.h:187:50: error: expected declaration specifiers or '...' before numeric constant 187 | #define mutex_lock(lock) mutex_lock_nested(lock, 0) | ^ drivers/leds/trigger/ledtrig-tty.c:97:9: note: in expansion of macro 'mutex_lock' 97 | mutex_lock(&trigger_data->mutex); | ^~~~~~~~~~ drivers/leds/trigger/ledtrig-tty.c:98:21: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token 98 | trigger_data->mode = tty_mode; | ^~ drivers/leds/trigger/ledtrig-tty.c:99:22: error: expected declaration specifiers or '...' before '&' token 99 | mutex_unlock(&trigger_data->mutex); | ^ drivers/leds/trigger/ledtrig-tty.c:101:9: error: expected identifier or '(' before 'return' 101 | return ret; | ^~~~~~ drivers/leds/trigger/ledtrig-tty.c:102:1: error: expected identifier or '(' before '}' token 102 | } | ^ cc1: some warnings being treated as errors vim +/ret +80 drivers/leds/trigger/ledtrig-tty.c 74 75 static ssize_t tty_led_mode_store(struct device *dev, 76 struct device_attribute *attr, const char *buf, 77 size_t size) 78 { > 79 struct ledtrig_tty_data *trigger_data = led_trigger_get_drvdata(dev); > 80 ssize_t ret = size; 81 enum tty_led_mode tty_mode = __TTY_LED_MAX; 82 int i; 83 84 /* Check for new line in string*/ 85 if (size > 0 && buf[size - 1] == '\n') 86 size -= 1; 87 88 for (i = 0; i <= __TTY_LED_LAST; i++) 89 if (strncmp(buf, mode[i], size) == 0) 90 tty_mode = i; > 91 break; 92 } 93 94 if (tty_mode > __TTY_LED_LAST) 95 return -EINVAL; 96 97 mutex_lock(&trigger_data->mutex); 98 trigger_data->mode = tty_mode; 99 mutex_unlock(&trigger_data->mutex); 100 101 return ret; 102 } 103 static DEVICE_ATTR_RW(tty_led_mode); 104 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
