Hello, here commes v3 of this series to add additional tty_led_modes. v3: Changes compared to the v2 patchset with 20230217094403.1574468-1-fe@xxxxxxxxxx are. Addressed review comments by Greg K-H are: tty.h: - Fix first comment line and remark -%ENOTTY for the new function 'tty_get_mget' to make a proper kernel doc. - Add the return value -%ENOTTY again, I thought it was no longer needed. v2: Changes compared to the initial patchset with 20230213140638.620206-1-fe@xxxxxxxxxx are. Addressed review comments by Jiri Slaby are: tty.h: - Fix compilation error because of wrong rebaseing - Remove empty lines - Use new 'tty_get_mget' in 'tty_tiocmget' ledtrg-tty.c: - Update commit description - Use enum for tty_led_mod in struct ledtrig_tty_date - Rename sysfs file from 'mode' to 'tty_led_mode' - Change tty_led_mode show function to use loop instead of switch/case - Change tty_led_mode store function to use loop instead of switch/case - Check return value of function tty_get_mget Florian Eckert (2): tty: new helper function tty_get_mget trigger: ledtrig-tty: add additional modes .../ABI/testing/sysfs-class-led-trigger-tty | 16 ++ drivers/leds/trigger/ledtrig-tty.c | 146 ++++++++++++++++-- drivers/tty/tty_io.c | 28 +++- include/linux/tty.h | 1 + 4 files changed, 170 insertions(+), 21 deletions(-) -- 2.30.2
