Hi Florian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on tty/tty-next tty/tty-linus pavel-leds/for-next staging/staging-testing staging/staging-next staging/staging-linus linus/master v6.2-rc8 next-20230213] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Florian-Eckert/tty-new-helper-function-tty_get_mget/20230213-223413 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing patch link: https://lore.kernel.org/r/20230213140638.620206-2-fe%40dev.tdt.de patch subject: [PATCH 1/2] tty: new helper function tty_get_mget config: x86_64-randconfig-a002-20230213 (https://download.01.org/0day-ci/archive/20230214/202302140339.1vFSjZ1M-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/096ca9c9428ec2a8ebab4af0798461e66585cdde git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Florian-Eckert/tty-new-helper-function-tty_get_mget/20230213-223413 git checkout 096ca9c9428ec2a8ebab4af0798461e66585cdde # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/misc/bcm-vk/ drivers/tty/ fs/proc/ init/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202302140339.1vFSjZ1M-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): In file included from drivers/tty/tty_port.c:8: include/linux/tty.h:423:3: error: expected ')' struct serial_icounter_struct *icount); ^ include/linux/tty.h:422:19: note: to match this '(' int tty_get_icount(struct tty_struct *tty ^ >> drivers/tty/tty_port.c:266:2: warning: implicit conversion from 'unsigned long' to 'unsigned int' changes value from 18446744073709551615 to 4294967295 [-Wconstant-conversion] INIT_KFIFO(port->xmit_fifo); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kfifo.h:130:69: note: expanded from macro 'INIT_KFIFO' __kfifo->mask = __is_kfifo_ptr(__tmp) ? 0 : ARRAY_SIZE(__tmp->buf) - 1;\ ~ ~~~~~~~~~~~~~~~~~~~~~~~^~~ 1 warning and 1 error generated. -- In file included from fs/proc/array.c:62: include/linux/tty.h:423:3: error: expected ')' struct serial_icounter_struct *icount); ^ include/linux/tty.h:422:19: note: to match this '(' int tty_get_icount(struct tty_struct *tty ^ In file included from fs/proc/array.c:64: >> include/linux/mman.h:154:9: warning: division by zero is undefined [-Wdivision-by-zero] _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/mman.h:132:21: note: expanded from macro '_calc_vm_trans' : ((x) & (bit1)) / ((bit1) / (bit2)))) ^ ~~~~~~~~~~~~~~~~~ 1 warning and 1 error generated. -- In file included from drivers/misc/bcm-vk/bcm_vk_dev.c:20: In file included from drivers/misc/bcm-vk/bcm_vk.h:18: include/linux/tty.h:423:3: error: expected ')' struct serial_icounter_struct *icount); ^ include/linux/tty.h:422:19: note: to match this '(' int tty_get_icount(struct tty_struct *tty ^ >> drivers/misc/bcm-vk/bcm_vk_dev.c:1320:6: warning: shift count >= width of type [-Wshift-count-overflow] DMA_BIT_MASK(BCM_VK_DMA_BITS)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK' #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1)) ^ ~~~ 1 warning and 1 error generated. vim +266 drivers/tty/tty_port.c 9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 260 9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 261 void tty_port_free_xmit_buf(struct tty_port *port) 9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 262 { 44e4909e453eaa drivers/char/tty_port.c Alan Cox 2009-11-30 263 mutex_lock(&port->buf_mutex); 9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 264 free_page((unsigned long)port->xmit_buf); 9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 265 port->xmit_buf = NULL; 4e2a44c1408b6a drivers/tty/tty_port.c Jiri Slaby 2022-01-24 @266 INIT_KFIFO(port->xmit_fifo); 44e4909e453eaa drivers/char/tty_port.c Alan Cox 2009-11-30 267 mutex_unlock(&port->buf_mutex); 9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 268 } 9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 269 EXPORT_SYMBOL(tty_port_free_xmit_buf); 9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 270 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
