On Wed, Jan 25, 2023 at 7:37 PM Henning Schild <henning.schild@xxxxxxxxxxx> wrote: > Am Tue, 24 Jan 2023 15:46:01 +0200 > schrieb Andy Shevchenko <andy.shevchenko@xxxxxxxxx>: > > On Tue, Jan 24, 2023 at 3:35 PM Henning Schild > > <henning.schild@xxxxxxxxxxx> wrote: > > > Am Tue, 24 Jan 2023 11:46:34 +0200 > > > schrieb Andy Shevchenko <andy.shevchenko@xxxxxxxxx>: ... > > > I would like to keep the number of files and CONFIG switches low, > > > with a focus on the config switches. Every new CONFIG=y/m has to be > > > requested in countless distros. So far i only dealt with debian > > > where ubuntu might follow, did not check others with recent enough > > > kernels ... like fedora if they have the SIMATIC stuff turned on or > > > need to be asked to do so. > > > > If you put the proper defaults, you can get good results without > > torturing distro configurations. > > Meaning i could try sending a patch to set "default m" for all three > SIEMENS_SIMATIC_IPC > SIEMENS_SIMATIC_IPC_WDT > LEDS_SIEMENS_SIMATIC_IPC No, default to another symbol which will be the core part. Again, look how 8250 is organized. There is no default m (at least new ones, I don't remember about any historical defaults as such). > > I was so far too shy for that. I would even go further and add > GPIO_F7188X > W83627HF_WDT > > > See how 8250 has been splitting over the time, we have +~5 new Kconfig > > options and their defaults are to keep the current behaviour without > > the user needing to do anything in their configurations. -- With Best Regards, Andy Shevchenko
