On 12/22/22 15:56, Pavel Machek wrote:
On Thu 2022-12-22 15:01:44, Marek Vasut wrote:
On 12/22/22 14:50, Pavel Machek wrote:
Hi!
This part I understand. What is not clear to me is, why is 'label' being
un-deprecated.
It shouldn't be. It seems to be Pavel's ad-hoc decision.
Is there a majority agreement that the "label" property remains
deprecated?
If so, I would say we can mark the label as deprecated.
On the other hand, the new generated standardized sysfs name does not seem
to provide a full replacement for the "label" property.
What is still missing?
Having reasonable naming of the LEDs is pre-requisite for deprecating
label property.
As far as I can tell, function and function-enumerator is the reasonable
naming. Jacek seem to confirm that. I would say, label can be deprecated .
What is the counter-argument for why it should NOT be deprecated ?
When the label is no longer neccessary for naming leds, it can be
deprecated. AFAICT, that is currently not the case.
I'm sorry, this is not a counter-argument, this is hand-waving .
Do you have anything to back your claim that the label is currently
still needed, contrary to what the DT bindings document claims for
years? "This property is deprecated - use 'function' and 'color'
properties instead. function-enumerator has no effect when this property
is present."
"
commit c5d18dd6b64e09dd6984bda9bdd55160af537a8c
Date: Sun Jun 9 20:19:04 2019 +0200
dt-bindings: leds: Add properties for LED name construction
Introduce dedicated properties for conveying information about
LED function and color. Mark old "label" property as deprecated.
Additionally function-enumerator property is being provided
for the cases when neither function nor color can be used
for LED differentiation.
"
It seems the function and function-enumerator is very much the
replacement for label, except standardized. If that's not the case, do
elaborate. If there is a special case that is not covered by it, do
point it out.
