Re: [PATCH V3 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 09, 2022 at 10:27:59AM +0100, Linus Walleij wrote:
> On Wed, Nov 9, 2022 at 10:11 AM chengwei <larry.lai@xxxxxxxxxxxxxxx> wrote:

...

> > +config PINCTRL_UPBOARD
> > +       tristate "UP board FPGA pin controller"
> > +       depends on ACPI
> > +       depends on MFD_UPBOARD_FPGA
> > +       depends on X86
> 
> This is Andy territory as it is x86 and ACPI but...

It seems they forgot paying the respect to the reviewers by Cc'ing them.

...

> So this looks like it should be uncommented and used or deleted?
> It just looks unfinished, and this patch is not an RFC.

I'm wondering why it has v3 and not RFC in the Subject. So, no need to spend
time right now in reviewing this.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux