Re: [PATCH v10 0/2] Introduce block device LED trigger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/7/22 07:16, torvic9@xxxxxxxxxxx wrote:
Hi Ian,

with a heavily patched Linux 6.0-rc4 with kfence, kmemleak and slub_debug I get the
following splat at boot:

Sorry about that!  I'm not sure how that slipped throgh, as I was sure
that I tested the new version before I sent it off.

Basically, I messed up while cleaning up the function parameter names,
so you need to apply this:

--- drivers/leds/trigger/ledtrig-blkdev.c.old 2022-09-07 10:00:26.194484681 -0500 +++ drivers/leds/trigger/ledtrig-blkdev.c 2022-09-04 11:36:16.107690614 -0500
@@ -540,7 +540,7 @@
                return ERR_PTR(-ENOMEM);

bdev = blkdev_get_by_path(strim(buf), BLKDEV_TRIG_FMODE, THIS_MODULE);
-       kfree(path);
+       kfree(buf);
        return bdev;
 }

I'm not 100% sure if this is an issue with ledtrig_blkdev or something else,
but I thought I'll let you know about it.
I have not been able to test this on a vanilla kernel yet.

Defnintely my fault.

Other than that, I hope this patchset gets included in upstream.
I have been using it for a long time now and found it very useful.

It's really hard to know if anyone is interested in/using this, so
that's great to hear.

--
========================================================================
Google                                      Where SkyNet meets Idiocracy
========================================================================




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux