On Wed, May 18, 2022 at 10:22:14AM +0200, Krzysztof Kozlowski wrote:
> The multi-led node defined address/size cells, so it intended to have
> children with unit addresses.
>
> The second multi-led's reg property defined three LED indexes within one
> reg item, which is not correct - these are three separate items.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> Cc: Kyle Swenson <kyle.swenson@xxxxxxxx>
> ---
> .../devicetree/bindings/leds/leds-lp50xx.yaml | 22 ++++++++++++-------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> index f12fe5b53f30..dc1ac905bb91 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> @@ -99,35 +99,41 @@ examples:
> color = <LED_COLOR_ID_RGB>;
> function = LED_FUNCTION_CHARGING;
>
> - led-0 {
> + led@0 {
> + reg = <0x0>;
> color = <LED_COLOR_ID_RED>;
> };
>
> - led-1 {
> + led@1 {
> + reg = <0x1>;
> color = <LED_COLOR_ID_GREEN>;
> };
>
> - led-2 {
> + led@2 {
> + reg = <0x2>;
> color = <LED_COLOR_ID_BLUE>;
> };
> };
>
> multi-led@2 {
> #address-cells = <1>;
> - #size-cells = <2>;
> - reg = <0x2 0x3 0x5>;
> + #size-cells = <0>;
> + reg = <0x3>, <0x4>, <0x5>;
The unit-address is 2, but the reg value is 3?
> color = <LED_COLOR_ID_RGB>;
> function = LED_FUNCTION_STANDBY;
>
> - led-6 {
> + led@3 {
> + reg = <0x3>;
> color = <LED_COLOR_ID_RED>;
> };
>
> - led-7 {
> + led@4 {
> + reg = <0x4>;
> color = <LED_COLOR_ID_GREEN>;
> };
>
> - led-8 {
> + led@5 {
> + reg = <0x5>;
> color = <LED_COLOR_ID_BLUE>;
> };
> };
> --
> 2.32.0
>
>
