of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not needed anymore.
When of_find_device_by_node() fails, of_node_put() is missing.
Fixes: 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors")
Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
---
Changes in v2:
- call of_node_put() right after of_find_device_by_node() to clean code.
v1 link: https://lore.kernel.org/all/20220512050253.8987-1-linmq006@xxxxxxxxx/
---
drivers/leds/leds-netxbig.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
index 77213b79f84d..bf9e51aa9d84 100644
--- a/drivers/leds/leds-netxbig.c
+++ b/drivers/leds/leds-netxbig.c
@@ -439,6 +439,7 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
return -EINVAL;
}
gpio_ext_pdev = of_find_device_by_node(gpio_ext_np);
+ of_node_put(gpio_ext_np);
if (!gpio_ext_pdev) {
dev_err(dev, "Failed to find platform device for gpio-ext\n");
return -ENODEV;
@@ -447,12 +448,10 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
gpio_ext = devm_kzalloc(dev, sizeof(*gpio_ext), GFP_KERNEL);
if (!gpio_ext) {
- of_node_put(gpio_ext_np);
ret = -ENOMEM;
goto put_device;
}
ret = netxbig_gpio_ext_get(dev, gpio_ext_dev, gpio_ext);
- of_node_put(gpio_ext_np);
if (ret)
goto put_device;
pdata->gpio_ext = gpio_ext;
--
2.25.1
