On Thu, May 05, 2022 at 04:21:33PM +0200, Rafał Miłecki wrote: > On 5.05.2022 16:02, Ansuel Smith wrote: > > On Thu, May 05, 2022 at 03:55:07PM +0200, Rafał Miłecki wrote: > > > From: Rafał Miłecki <rafal@xxxxxxxxxx> > > > > > > Some LEDs are designed to represent a state of another device. That may > > > be USB port, Ethernet interface, CPU, hard drive and more. > > > > > > We already have support for LEDs that are designed to indicate USB port > > > (e.g. light on when USB device gets connected). There is DT binding for > > > that and Linux implementation in USB trigger. > > > > > > This patchset adds support for describing LEDs that should react to > > > Ethernet interface status. That is commonly used in routers. They often > > > have LED to display state and activity of selected physical port. It's > > > also common to have multiple LEDs, each reacting to a specific link > > > speed. > > > > > > > I notice this is specific to ethernet speed... I wonder if we should > > expand this also to other thing like duplex state or even rx/tx. > > I didn't see any router with separated Rx/Tx LEDs, but it still sounds > like a valid case. > Not a normal configuration but it's doable. For qca8k you can really set the led to do whatever you want. > We could add flags for that in proposed field like: > trigger-sources = <&port (SPEED_1000 | LINK | TX)>; > > Or add separated field for non-speed flags like: > trigger-sources = <&port SPEED_1000 (LINK | TX)>; > > Let's see what DT experts say about it. -- Ansuel
