On Thu, May 05, 2022 at 03:29:26AM +0200, Andrew Lunn wrote: > On Tue, May 03, 2022 at 05:16:31PM +0200, Ansuel Smith wrote: > > Add additional hardware only triggers commonly supported by switch LEDs. > > > > Additional modes: > > link_10: LED on with link up AND speed 10mbps > > link_100: LED on with link up AND speed 100mbps > > link_1000: LED on with link up AND speed 1000mbps > > half_duplex: LED on with link up AND half_duplex mode > > full_duplex: LED on with link up AND full duplex mode > > > > Additional blink interval modes: > > blink_2hz: LED blink on any even at 2Hz (250ms) > > blink_4hz: LED blink on any even at 4Hz (125ms) > > blink_8hz: LED blink on any even at 8Hz (62ms) > > I would suggest separating blink intervals into a patch of their own, > because they are orthogonal to the other modes. Most PHYs are not > going to support them, or they have to be the same across all LEDs, or > don't for example make sense with duplex etc. We need to first > concentrate on the basics, get that correct. Then we can add nice to > have features like this. > > Andrew Okok will just drop this. I agree that adds additional complexity to the code and would make this even harder to merge. -- Ansuel
