Re: [RFC PATCH v6 10/11] net: dsa: qca8k: add LEDs support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ansuel Smith <ansuelsmth@xxxxxxxxx>
Subject: Re: [RFC PATCH v6 10/11] net: dsa: qca8k: add LEDs support
From: Andrew Lunn <andrew@xxxxxxx>
Date: Thu, 5 May 2022 03:55:26 +0200
Cc: Vivien Didelot <vivien.didelot@xxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, Vladimir Oltean <olteanv@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Pavel Machek <pavel@xxxxxx>, John Crispin <john@xxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-leds@xxxxxxxxxxxxxxx
In-reply-to: <20220503151633.18760-11-ansuelsmth@gmail.com>
References: <20220503151633.18760-1-ansuelsmth@gmail.com> <20220503151633.18760-11-ansuelsmth@gmail.com>

> +		ret = fwnode_property_read_string(led, "default-state", &state);

You should probably use led_default_state led_init_default_state_get()

    Andrew

Follow-Ups:
- Re: [RFC PATCH v6 10/11] net: dsa: qca8k: add LEDs support
  - From: Ansuel Smith

References:
- [RFC PATCH v6 00/11] Adds support for PHY LEDs with offload triggers
  - From: Ansuel Smith
- [RFC PATCH v6 10/11] net: dsa: qca8k: add LEDs support
  - From: Ansuel Smith

Prev by Date: Re: [RFC PATCH v6 10/11] net: dsa: qca8k: add LEDs support
Next by Date: Re: [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds
Previous by thread: Re: [RFC PATCH v6 10/11] net: dsa: qca8k: add LEDs support
Next by thread: Re: [RFC PATCH v6 10/11] net: dsa: qca8k: add LEDs support
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]