Hi Sven,
I did consider placing the property into the multicolor's sub nodes.
However, multicolor LEDs are not required to have firmware sub nodes. At
least the multicolor class API does not make any assumptions about this.
One possible solution that I came up with is to do something like this:
multi-led {
color = <LED_COLOR_ID_RGB>;
default-intensities = <
LED_COLOR_ID_RED 100
LED_COLOR_ID_GREEN 0
LED_COLOR_ID_BLUE 0
>;
led-0 {
color = <LED_COLOR_ID_RED>;
};
led-1 {
color = <LED_COLOR_ID_GREEN>;
};
led-2 {
color = <LED_COLOR_ID_BLUE>;
};
};
This requires the array to be twice as long as the number of colors (sub
LEDs). Each color identifier would be paired with the initial intensity.
This would limit number of LEDs per color to 1. However, I believe, this
limitation is already there today.
Thoughts?
Best regards,
Sven
On 5/4/22 09:17, Sven Schuchmann wrote:
Hello Sven,
-----Ursprüngliche Nachricht-----
Von: Sven Schwermer <sven@xxxxxxxxxxxxxxxx>
Gesendet: Dienstag, 3. Mai 2022 20:59
An: Sven Schuchmann <schuchmann@xxxxxxxxxxxxxxxxx>; linux-leds@xxxxxxxxxxxxxxx
Cc: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>; pavel@xxxxxx
Betreff: Re: AW: [PATCH v2 1/2] dt-bindings: leds: Add multi-color default-intensities
property
Hi Sven,
Thanks for making me aware of your patch series. My series would work
similar to yours, i.e. the default-intensities property would be on the
same level as color = <LED_COLOR_ID_RGB>.
However, the concern voiced by Jacek is relevant for my patch as well,
see
https://lore.kernel.org/all/d5631e35-cd62-106f-2ec4-de3163367bc0@xxxxxxxxx/
However, I do not know how to resolve the issue. Perhaps somebody from
the list has ideas?
I also do not have an idea. But maybe we can talk about how the definition
should look like in DT. As far as I understood with your patch I would
have define the LED as follows:
multi-led@0 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0>;
color = <LED_COLOR_ID_RGB>;
default-intensities = <100 0 0> <----
function = "eee-led-status";
led-0 {
color = <LED_COLOR_ID_RED>;
};
led-1 {
color = <LED_COLOR_ID_GREEN>;
};
led-2 {
color = <LED_COLOR_ID_BLUE>;
};
};
Maybe it is better to define per Color like this:
multi-led@0 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0>;
color = <LED_COLOR_ID_RGB>;
function = "eee-led-status";
led-0 {
color = <LED_COLOR_ID_RED>;
default-intensity = 100
};
led-1 {
color = <LED_COLOR_ID_GREEN>;
default-intensity = 0
};
led-2 {
color = <LED_COLOR_ID_BLUE>;
default-intensity = 0
};
};
I think this could then be handled by RGBW LEDs also.
Best Regards,
Sven
Best regards,
Sven
On 5/3/22 15:50, Sven Schuchmann wrote:
Hello Sven,
tried this some time ago for the LP50XX
https://lore.kernel.org/all/20210204143726.27977-1-schuchmann@xxxxxxxxxxxxxxxxx/
Your solution looks much better.
Could you give an example of how to use it?
My Configuration at this time looks like this:
multi-led@0 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0>;
color = <LED_COLOR_ID_RGB>;
function = "eee-led-status";
led-0 {
color = <LED_COLOR_ID_RED>;
};
led-1 {
color = <LED_COLOR_ID_GREEN>;
};
led-2 {
color = <LED_COLOR_ID_BLUE>;
};
};
Where do I put the "default-intensities"?
Regards,
Sven
-----Ursprüngliche Nachricht-----
Von: Sven Schwermer <sven@xxxxxxxxxxxxxxxx>
Gesendet: Dienstag, 3. Mai 2022 13:27
An: linux-leds@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; pavel@xxxxxx;
robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; dmurphy@xxxxxx;
devicetree@xxxxxxxxxxxxxxx
Cc: Sven Schwermer <sven.schwermer@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Betreff: [PATCH v2 1/2] dt-bindings: leds: Add multi-color default-intensities property
From: Sven Schwermer <sven.schwermer@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
This allows to assign intensity values to the indivisual sub LEDs
(colors) at driver probe time, i.e. most commonly at kernel boot time.
This is crucial for setting a specific color early in the boot process.
Signed-off-by: Sven Schwermer <sven.schwermer@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
---
Notes:
V1->V2: no changes
.../devicetree/bindings/leds/leds-class-multicolor.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
index 37445c68cdef..c483967a847c 100644
--- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
@@ -31,6 +31,13 @@ patternProperties:
include/linux/leds/common.h.
enum: [ 8, 9 ]
+ default-intensities:
+ description: |
+ This parameter, if present, sets the initial intensities of the
+ individual colors. This array must have the same length as the
+ multi-color LED has sub LEDs (colors).
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+
$ref: "common.yaml#"
required:
--
2.36.0
