On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > From: Arnd Bergmann <arnd@xxxxxxxx> > > The three eseries machines have very similar drivers for audio, all > using the mach/eseries-gpio.h header for finding the gpio numbers. > > Change these to use gpio descriptors to avoid the header file > dependency. > > I convert the _OFF gpio numbers into GPIO_ACTIVE_LOW ones for > consistency here. > > Acked-by: Mark Brown <broonie@xxxxxxxxxx> > Acked-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: alsa-devel@xxxxxxxxxxxxxxxx > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Nice use of active low. Maybe I would simply have dropped the _OFF suffix on these GPIO lines as it can be confusing now that their active level is encoded but no big deal. Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij
