Re: [PATCH] leds: lm3692x: Return 0 from remove callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> The only difference between returning zero or a non-zero value is that
> for the non-zero case the i2c will print a generic error message
> ("remove failed (-ESOMETHING), will be ignored").
> 
> In this case however the driver itself already emitted a more helpful
> error message, so the additional error message isn't helpful at all.
> 
> The long-term goal is to make the i2c remove callback return void, making
> all implementations return 0 is preparatory work for this change.

Thanks, applied.
									Pavel
									
-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux